Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented May 18, 2024

Description of proposed changes

As mentioned in #3244 (comment):

The pygmt.print_clib_info function was initially added in #176 but has been replaced by pygmt.show_versions in #466 (first appear in v0.1.2).

In this PR, a new private function _get_clib_info is added which returns a dictionary instead of printing a long string.

It's time to retire the print_clib_info function. Since it's rarely used, I think we can just remove it without a deprecation warning. Of course, we should do it in a separate PR so that at least we have a deprecation entry in the v0.13.0 changelog.

This PR removes the print_clib.info function.

@seisman seisman added the deprecation Deprecating a feature label May 18, 2024
@seisman seisman added this to the 0.13.0 milestone May 18, 2024
@seisman seisman added the needs review This PR has higher priority and needs review. label May 18, 2024
@seisman seisman requested a review from a team May 18, 2024 11:29
@seisman seisman removed the needs review This PR has higher priority and needs review. label May 21, 2024
@seisman seisman merged commit eaca67d into main May 21, 2024
@seisman seisman deleted the print_clib_info branch May 21, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants